Skip to content

chore(bigquery-jdbc): share agent skills and add module AGENTS.md - #14994

Merged
logachev merged 4 commits into
mainfrom
kirl/skills
Nov 16, 2026
Merged

logachev merged 4 commits into
mainfrom
kirl/skills

Conversation

@logachev

@logachev logachev commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Adds two shared agent skills under java-bigquery-jdbc/.agents/skills/:
    • bigquery-jdbc-testing: conventions for unit and integration tests.
    • bigquery-jdbc-prepare-pr: an independent review by a different model
      before a PR is opened or updated. Java changes get the full loop; docs,
      config and other non-Java changes get a single round.
  • Adds java-bigquery-jdbc/AGENTS.md: module guardrails, commands, and an index
    of the skills.
  • Adds a .claude/skills symlink to .agents/skills, so Claude Code finds the
    same skills.
  • .gitignore: only .agents/skills/ and the .claude/skills symlink are
    tracked. Everything else under .agents/ and .claude/ stays ignored, so
    personal rules and local settings stay local.
  • DEVELOPMENT.md: replaces two class names that do not exist
    (BigQueryJdbcTypeMappings, BigQueryCoercion) with BigQueryTypeRegistry
    and TypeDescriptor, corrects the make lint description (it only runs the
    formatter), and points to AGENTS.md.

Why

Agent guidance for this module lived in individual developers' ignored
.agents/ directories. This makes it versioned and shared.

How it was tested

Docs and config only. No Java changed, so no unit or integration tests were run.

  • Every class, method, constant and make target named in the two skills,
    AGENTS.md and the edited DEVELOPMENT.md lines was checked against
    origin/main with git grep.
  • .gitignore behaviour was checked with git check-ignore.
  • Jetski loaded both skills from .agents/skills/ in a session opened in
    java-bigquery-jdbc/ (before prepare-pr was renamed).
  • Not tested: discovery by Claude Code and Gemini CLI, and discovery from a
    session opened at the monorepo root.

Risks and notes

@logachev
logachev requested review from a team as code owners November 12, 2026 22:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new agent skill documentation file (SKILL.md) under .agents/skills/bigquery-jdbc-testing to define conventions for writing and refactoring unit and integration tests in the BigQuery JDBC driver, along with corresponding symlinks for Claude and Gemini. To track these files, .agents/ was removed from .gitignore. The reviewer correctly pointed out that completely removing .agents/ from .gitignore might track unwanted agent-generated files, and suggested a more targeted approach to ignore .agents/* while explicitly unignoring .agents/skills/.

Comment thread java-bigquery-jdbc/.gitignore Resolved
…S.md

- Rename prepare-pr to bigquery-jdbc-prepare-pr and remove its
  contradictions: the flowchart no longer says to push, WONTFIX is a
  defined response, pushback escalation is stated once, and findings
  attached to an APPROVE have a rule.
- bigquery-jdbc-prepare-pr: add a single-round path for non-Java changes,
  a sync-with-main step, the full unit suite before round 1 and on the
  final code, untracked-file handling, and reviewer prompts on stdin.
- bigquery-jdbc-testing: state base classes as a rule for new tests only,
  use the real BigQueryConnectionTest example, and point to ITBase instead
  of listing its members.
- Add java-bigquery-jdbc/AGENTS.md with module guardrails and a skill index.
- .gitignore: ignore .claude/ except the shared skills symlink.
- DEVELOPMENT.md: replace nonexistent BigQueryJdbcTypeMappings and
  BigQueryCoercion with BigQueryTypeRegistry and TypeDescriptor, and
  describe make lint as formatter-only.
@keshavdandeva keshavdandeva changed the title chore(bigquery-jdbc): add testing skills chore(bigquery-jdbc): share agent skills and add module AGENTS.md Nov 16, 2026
@logachev
logachev merged commit 4bbe809 into main Nov 16, 2026
200 checks passed
@logachev
logachev deleted the kirl/skills branch November 16, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants