Repository navigation
chore(bigquery-jdbc): share agent skills and add module AGENTS.md - #14994
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new agent skill documentation file (SKILL.md) under .agents/skills/bigquery-jdbc-testing to define conventions for writing and refactoring unit and integration tests in the BigQuery JDBC driver, along with corresponding symlinks for Claude and Gemini. To track these files, .agents/ was removed from .gitignore. The reviewer correctly pointed out that completely removing .agents/ from .gitignore might track unwanted agent-generated files, and suggested a more targeted approach to ignore .agents/* while explicitly unignoring .agents/skills/.
keshavdandeva
approved these changes
Nov 13, 2026
Neenu1995
approved these changes
Nov 16, 2026
…S.md - Rename prepare-pr to bigquery-jdbc-prepare-pr and remove its contradictions: the flowchart no longer says to push, WONTFIX is a defined response, pushback escalation is stated once, and findings attached to an APPROVE have a rule. - bigquery-jdbc-prepare-pr: add a single-round path for non-Java changes, a sync-with-main step, the full unit suite before round 1 and on the final code, untracked-file handling, and reviewer prompts on stdin. - bigquery-jdbc-testing: state base classes as a rule for new tests only, use the real BigQueryConnectionTest example, and point to ITBase instead of listing its members. - Add java-bigquery-jdbc/AGENTS.md with module guardrails and a skill index. - .gitignore: ignore .claude/ except the shared skills symlink. - DEVELOPMENT.md: replace nonexistent BigQueryJdbcTypeMappings and BigQueryCoercion with BigQueryTypeRegistry and TypeDescriptor, and describe make lint as formatter-only.
Neenu1995
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
java-bigquery-jdbc/.agents/skills/:bigquery-jdbc-testing: conventions for unit and integration tests.bigquery-jdbc-prepare-pr: an independent review by a different modelbefore a PR is opened or updated. Java changes get the full loop; docs,
config and other non-Java changes get a single round.
java-bigquery-jdbc/AGENTS.md: module guardrails, commands, and an indexof the skills.
.claude/skillssymlink to.agents/skills, so Claude Code finds thesame skills.
.gitignore: only.agents/skills/and the.claude/skillssymlink aretracked. Everything else under
.agents/and.claude/stays ignored, sopersonal rules and local settings stay local.
DEVELOPMENT.md: replaces two class names that do not exist(
BigQueryJdbcTypeMappings,BigQueryCoercion) withBigQueryTypeRegistryand
TypeDescriptor, corrects themake lintdescription (it only runs theformatter), and points to
AGENTS.md.Why
Agent guidance for this module lived in individual developers' ignored
.agents/directories. This makes it versioned and shared.How it was tested
Docs and config only. No Java changed, so no unit or integration tests were run.
AGENTS.mdand the editedDEVELOPMENT.mdlines was checked againstorigin/mainwithgit grep..gitignorebehaviour was checked withgit check-ignore..agents/skills/in a session opened injava-bigquery-jdbc/(beforeprepare-prwas renamed).session opened at the monorepo root.
Risks and notes
.claude/skillsis the first symlink in the repository. A Windows checkoutwithout symlink support gets a plain text file, and Claude Code then finds no
skills. Builds are unaffected.
mainmust bemerged into this branch before merge.
bigquery-jdbc-prepare-prcan send a diff to another vendor's CLI (Gemini CLIfrom Claude Code and the reverse). The skill excludes security fixes that are
not public yet. Reviewers should confirm that default is acceptable.